Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp InboundHttp2ToHttpAdapter builder API #4582

Closed
wants to merge 1 commit into from
Closed

Revamp InboundHttp2ToHttpAdapter builder API #4582

wants to merge 1 commit into from

Conversation

trustin
Copy link
Member

@trustin trustin commented Dec 17, 2015

Related: #4572 #4574

Motivation:

Consistency in our builder API design

Modifications:

  • Add AbstractInboundHttp2ToHttpAdapterBuilder
  • Replace the old 'Builder's with InboundHttp2ToHttpAdapterBuilder and
    InboundHttp2ToHttpPriorityAdapterBuilder

Result:

Builder API consistency

@trustin trustin added this to the 4.1.0.CR1 milestone Dec 17, 2015
@trustin
Copy link
Member Author

trustin commented Dec 17, 2015

@Scottmitch PTAL

@trustin trustin force-pushed the builder_api_3 branch 2 times, most recently from 9abde14 to 69d341b Compare December 17, 2015 07:24
@trustin
Revamp InboundHttp2ToHttpAdapter builder API
69d341b 
Related: #4572 #4574

Motivation:

Consistency in our builder API design

Modifications:

- Add AbstractInboundHttp2ToHttpAdapterBuilder
- Replace the old 'Builder's with InboundHttp2ToHttpAdapterBuilder and
  InboundHttp2ToHttpPriorityAdapterBuilder

Result:

Builder API consistency
normanmaurer
normanmaurer reviewed Dec 17, 2015
View reviewed changes
...tp2/src/main/java/io/netty/handler/codec/http2/AbstractInboundHttp2ToHttpAdapterBuilder.java
* for the current connection
*/
protected AbstractInboundHttp2ToHttpAdapterBuilder(Http2Connection connection) {
this.connection = connection;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for null as this should never be null.

@normanmaurer
Copy link
Member

@trustin just one comment

@Scottmitch
Copy link
Member

lgtm

@trustin
Copy link
Member Author

trustin commented Dec 18, 2015

Cherry-picked after addressing the comment: b39380a (4.1)

@trustin trustin closed this Dec 18, 2015
@trustin trustin deleted the builder_api_3 branch December 18, 2015 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Scottmitch Scottmitch

Labels
feature
Projects
None yet
Milestone
4.1.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trustin @normanmaurer @Scottmitch @netkins